Port all scene parts except Images to new framework #2308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
📺 re_viewer
|
in order to react to the comments on #2304 with reasonable effort, I have to take things as a single PR :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Didn't get to finish images today. Time to put a checkpoint.
This ports all spatial scene parts except images. Minimal adjustments to the framework. Again the only known regression is 2d/3d scene picking
DRAFT: This does not target main but #2304
Checklist
PR Build Summary: https://build.rerun.io/pr/2308
Docs preview: https://rerun.io/preview/16c8c08/docs