Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup scripts for Mac M1/MacPort configuration #2169

Merged
merged 1 commit into from
May 19, 2023
Merged

Fix setup scripts for Mac M1/MacPort configuration #2169

merged 1 commit into from
May 19, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented May 17, 2023

What

This PR includes two minor changes needed to for the setup_dev.sh script to complete on my M1 machine with MacPorts:

  1. Add MacPorts in the list of supported package managers.
  2. Add --locked flag when installing cargo-deny

Without --locked, I would get the following error:

 = note: Undefined symbols for architecture arm64:
            "_iconv", referenced from:
                _git_fs_path_iconv in liblibgit2_sys-855562e07780fd1f.rlib(fs_path.o)
               (maybe you meant: _git_fs_path_iconv_clear, _git_fs_path_iconv_init_precompose , _git_fs_path_iconv )
            "_iconv_close", referenced from:
                _git_fs_path_direach in liblibgit2_sys-855562e07780fd1f.rlib(fs_path.o)
                _git_fs_path_iconv_clear in liblibgit2_sys-855562e07780fd1f.rlib(fs_path.o)
                _git_fs_path_diriter_free in liblibgit2_sys-855562e07780fd1f.rlib(fs_path.o)
                _git_fs_path_dirload in liblibgit2_sys-855562e07780fd1f.rlib(fs_path.o)
            "_iconv_open", referenced from:
                _git_fs_path_direach in liblibgit2_sys-855562e07780fd1f.rlib(fs_path.o)
                _git_fs_path_iconv_init_precompose in liblibgit2_sys-855562e07780fd1f.rlib(fs_path.o)
                _git_fs_path_diriter_init in liblibgit2_sys-855562e07780fd1f.rlib(fs_path.o)
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)


error: could not compile `cargo-deny` due to previous error

I haven't investigated why this is so, but the cargo-deny project always includes --locked in its installation instructions.

Checklist

PR Build Summary: {{ pr-build-summary }}

@jleibs jleibs added the 🧑‍💻 dev experience developer experience (excluding CI) label May 17, 2023
@jleibs
Copy link
Member

jleibs commented May 17, 2023

Thanks for the improvements!

@emilk emilk merged commit 09c255c into rerun-io:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants