-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wasm-bindgen
to 0.2.86
#2161
Conversation
@@ -31,4 +31,4 @@ env_logger = "0.10" | |||
# web dependencies: | |||
[target.'cfg(target_arch = "wasm32")'.dependencies] | |||
js-sys = "0.3" | |||
wasm-bindgen = "=0.2.84" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using "=…
here and below was a mistake. We have a Cargo.lock
file for that. We don't want force any potential users of our crates to use a specific wasm-bindgen version. However, we do want to force them to use at least 0.2.86 since it contains the critical fix for 2GiB RAM usage
Oh right, this needs a new CI docker image too… EDIT:
|
* Update wasm-bindgen to 0.2.86 * Prepare for new docker image * Switch the Dockerfile to use setup_web.sh --------- Co-authored-by: Jeremy Leibs <[email protected]>
What
Update
wasm-bindgen
to 0.2.86This release contains the fix for 2GiB memory usage, meaning we no longer need to use a forked version of wasm-bindgen-cli
Does not fix #2152
Tested in Firefo, Chromium, and Safari
Checklist
PR Build Summary: https://build.rerun.io/pr/2161