Replace complex uses of query_entity_with_primary with query_latest_single
#2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2122 by no longer warning on the spurious problem, which has no actual manifestation - it works as expected. I think it is a timing thing (loading the blueprint before any data has been loaded maybe?)
What
We have some "mono-components" (
Transform,TensorandViewCoordinates), which we only allow one of per entity. For those we have a nice helper function,query_latest_singlewhich is much simpler thanquery_entity_with_primary..This PR also adds a
result.warn_on_err_oncehelper which can be used to quickly log anErrand get anOption. Much better than ignoring the error. Ultimately i didn't need it in this PR, but I have missed it many other times, so it will come in use, I'm sure.Checklist
PR Build Summary: https://build.rerun.io/pr/2137