Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glb mesh data set downloads #2100

Merged
merged 2 commits into from
May 15, 2023
Merged

Fix glb mesh data set downloads #2100

merged 2 commits into from
May 15, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 12, 2023 •
edited by github-actions bot
Loading

Checklist

PR Build Summary: https://build.rerun.io/pr/2100

@Wumpf Wumpf added the examples Issues relating to the Rerun examples label May 12, 2023
emilk
emilk reviewed May 12, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a check for the status code so we catch this better next time

teh-cmc
teh-cmc requested changes May 15, 2023
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires fixing the downloader to check for status codes.

(Adding reviews so the PR leaves the "waiting-for-review" slot)

@Wumpf Wumpf requested a review from teh-cmc May 15, 2023 09:57
@Wumpf Wumpf merged commit bfd2115 into main May 15, 2023
@Wumpf Wumpf deleted the andreas/fix-glb-mesh-download branch May 15, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
examples Issues relating to the Rerun examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wumpf @emilk @teh-cmc