Python log_mesh_file: accept either path or bytes
#2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a user who accidentally passed in a path instead of bytes. That is an argument for named arguments, and for supporting both paths and file contents.
emilk
changed the title
log_mesh_file: accept either path or bytes
Wumpf
approved these changes
May 12, 2023
| @@ -67,7 +67,7 @@ def get_mesh_format(mesh: Trimesh) -> rr.MeshFormat: | |||
| try: | |||
| return { | |||
| ".glb": rr.MeshFormat.GLB, | |||
| # ".gltf": MeshFormat.GLTF, | |||
| # ".gltf": rr.MeshFormat.GLTF, | |||
There was a problem hiding this comment.
this is strange actually. We do support gltf.
There was a problem hiding this comment.
Until we have a test for it, I wouldn't say we do…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a user who accidentally passed in a path instead of bytes.
That is an argument for named arguments, and for supporting both paths and file contents.
This is a breaking change, but one that
mypycatches:…so let's hope our users uses
mypy!Checklist
PR Build Summary: https://build.rerun.io/pr/2098