Make sure rerun/rerun_py/re_viewer build info is updated on each build
#2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #2086
Maybe closes #1209
I generalized the rebuild-detection from
re_web_viewer_serverand reused it for other crates to ensure we generate new build info (e.g. the--versionstring) each time a crate is rebuilt. I also improved this code a bit, removing duplicate files from the output (I don't know if this was a problem, but can't hurt).I also fixed a bug in the
re_web_viewer_serverbuild.rsthat caused that crate to always be rebuilt, even if nothing had changed. This was because we didcargo:rerun-if-env-changedon a file that was no longer there,web_viewer/favicon.ico(should have beenweb_viewer/favicon.svg). I have now protected against future mishaps like that.Checklist
PR Build Summary: https://build.rerun.io/pr/2087