Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from egui_dock to egui_tiles #2082

Merged
merged 4 commits into from
May 11, 2023
Merged

Switch from egui_dock to egui_tiles #2082

merged 4 commits into from
May 11, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented May 10, 2023 •
edited by Wumpf
Loading

Closes #1897

egui_tiles

What

Replaces egui_dock with our new crate egui_tiles.

Functionality-wise extremely similar at this point, but perhaps with slightly nicer drag-and-drop.

Future PR:s will:

  • Show the tile tree hierarchy in the blueprint view
  • Use dynamic grid layouts instead of binary splits as the default heuristic

Checklist

PR Build Summary: https://build.rerun.io/pr/2082

@emilk emilk added ui concerns graphical user interface dependencies concerning crates, pip packages etc labels May 10, 2023
@emilk emilk marked this pull request as ready for review May 10, 2023 20:47
@Wumpf Wumpf self-requested a review May 11, 2023 07:00
Wumpf
Wumpf approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty straight forward!
still thinking showing contents while dragging is better, but I guess that's really just taste :)

@emilk
Copy link
Member Author

emilk commented May 11, 2023 •
edited
Loading

Maybe I should leave the original, but darken it or something. I'll do some experimentation.

@emilk emilk merged commit bd8a072 into main May 11, 2023
@emilk emilk deleted the emilk/integrate-egui_tile_tree branch May 11, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace egui_dock with a better layout system
2 participants
@emilk @Wumpf