Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing dependency install of mesh_to_sdf #2081

Merged
merged 2 commits into from
May 10, 2023
Merged

Fix failing dependency install of mesh_to_sdf #2081

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07391d5
Fix failing dependency install of mesh_to_sdf
Wumpf May 10, 2023
036460c
add comment
Wumpf May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/python/deep_sdf/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
mesh_to_sdf===0.0.14
-e git+https://github.com/marian42/mesh_to_sdf.git#egg=mesh_to_sdf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wth is this magic? "egg"? https://youtu.be/hl7-ZmJEB1E?t=24

Is it possible to add a comment here explaining wtf is going on and why we don't just depend on mesh_to_sdf like a normal dependency?

Copy link
Member Author

@Wumpf Wumpf May 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I watched the video you linked and it didn't help me understand anything about eggs.

I'm just following Pip's orders. But apparently that's what bundled python code is called https://stackoverflow.com/questions/2051192/what-is-a-python-egg
Turns out.. pythons.. lay eggs..

I also found out how to add comments to requirements.txt so I'll link to the ticket etc.

numpy
requests==2.28.1
rerun-sdk
Expand Down