Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_all.py: print output on sequential run failure #2079

Merged
merged 1 commit into from
May 10, 2023
Merged

run_all.py: print output on sequential run failure #2079

merged 1 commit into from
May 10, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented May 10, 2023 •
edited by github-actions bot
Loading

The assert returncode == 0 in the wait branch of run_py_example and run_saved_example would cause the script to stop immediately without printing the output of the example.

Checklist

PR Build Summary: https://build.rerun.io/pr/2079

@jprochazk jprochazk requested a review from Wumpf May 10, 2023 12:27
@jprochazk jprochazk added the 🧑‍💻 dev experience developer experience (excluding CI) label May 10, 2023
Wumpf
Wumpf approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and solves my problem 👍

@Wumpf Wumpf merged commit d597b29 into main May 10, 2023
@Wumpf Wumpf deleted the jan/fix-run-all-output branch May 10, 2023 12:55
jprochazk added a commit that referenced this pull request May 11, 2023
@jprochazk
print output on sequential run failure (#2079)
108c233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprochazk @Wumpf