Improvements to memory measurements and reporting #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
ui
emilk
reviewed
May 9, 2023
| @@ -1366,6 +1366,37 @@ fn memory_use_label_ui(ui: &mut egui::Ui, gpu_resource_stats: &WgpuResourcePoolS | |||
| format_number(gpu_resource_stats.num_textures), | |||
| format_number(gpu_resource_stats.num_buffers), | |||
| )); | |||
| } else { | |||
There was a problem hiding this comment.
We should also consider adding a fallback on the RSS, as found by bytes_resident() in crates/re_memory/src/memory_use.rs. Then we would never need to suggest the AccountingAllocator
There was a problem hiding this comment.
Btw, Arc-blroth/memory-stats#2 is fixed, so we should be able to get the RSS on Linux too (please check!)
There was a problem hiding this comment.
We now have fallbacks for all cases; but I still recommend setting up an AccountingAllocator because RSS is, as always, completely off the mark
teh-cmc
changed the title
AccountingAllocator
emilk
reviewed
May 9, 2023
emilk
reviewed
May 9, 2023
emilk
approved these changes
May 9, 2023
Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
jprochazk
pushed a commit
that referenced
this pull request
May 11, 2023
* guide users towards AccountingAllocator * web support * Update crates/re_viewer/src/app.rs Co-authored-by: Emil Ernerfeldt <[email protected]> * update memory-stats to 1.1 and always use statm * improvements, fallbacks and all sorts of fun * Update crates/re_viewer/src/app.rs Co-authored-by: Emil Ernerfeldt <[email protected]> * Update crates/re_viewer/src/app.rs Co-authored-by: Emil Ernerfeldt <[email protected]> * Update crates/re_viewer/src/app.rs Co-authored-by: Emil Ernerfeldt <[email protected]> * typo in suggestion --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2041
AccountingAllocatoravailable:Fallback to
RSS:Fallback to placeholder:
