Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "native_viewer is now an opt-in feature of the rerun library" #2067

Merged
merged 1 commit into from
May 9, 2023
Merged

Revert "native_viewer is now an opt-in feature of the rerun library" #2067

merged 1 commit into from
May 9, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented May 9, 2023 •
edited
Loading

Reverts #2064

Turns out cargo r -p rerun will no longer work, you need to run cargo r -p rerun --features native_viewer. Same for cargo install rerun for our users. This sucks.

> cargo r -p rerun
error: target `rerun` in package `rerun` requires the features: `native_viewer`
Consider enabling them by passing, e.g., `--features="native_viewer"`

Re-opens #1997

@emilk emilk mentioned this pull request May 9, 2023
Closed
@emilk emilk added 🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) and removed 🪳 bug Something isn't working labels May 9, 2023
@emilk emilk merged commit 603d09c into main May 9, 2023
@emilk emilk deleted the revert-2064-emilk/native-viewer-opt-in branch May 9, 2023 13:41
jprochazk pushed a commit that referenced this pull request May 11, 2023
@emilk @jprochazk
Revert "native_viewer is now an opt-in feature of the rerun libra…
20656f0 
…ry (#2064)" (#2067)

This reverts commit 697af91.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emilk