Check examples/python/requirements.txt in CI
#2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
added
🧑💻 dev experience
teh-cmc
approved these changes
May 9, 2023
|
Oh actually, would you mind adding an extra check to make sure the file is sorted please? |
|
I've had the taplo-cli install fail before, it's a bit strange 🤔 |
jprochazk
force-pushed
the
jan/check-example-requirements
branch
from
6ed9820 to
d95df4b
Compare
sorted alphabetically
also intentionally submit incorrect `requirements.txt` so that CI fails
jprochazk
force-pushed
the
jan/check-example-requirements
branch
from
d95df4b to
99cf2bc
Compare
jprochazk
added a commit
that referenced
this pull request
May 11, 2023
* add `check_requirements.py` * add `check_requirements.py` to CI checks * add missing requirements sorted alphabetically * check if requirements are sorted also intentionally submit incorrect `requirements.txt` so that CI fails * fix `examples/python/requirements.txt`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2027
check_requirements.pyto check if theexamples/python/requirements.txtfile contains all every example'srequirements.txtChecklist
PR Build Summary: https://build.rerun.io/pr/2063