Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect 2D camera for scenes with negative 2D coordinates #2051

Merged
merged 1 commit into from
May 5, 2023
Merged

Fix incorrect 2D camera for scenes with negative 2D coordinates #2051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/re_viewer/src/ui/view_spatial/ui_2d.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,8 @@ fn setup_target_config(
// For simplicity (and to reduce surprises!) we always render with a pinhole camera.
// Make up a default pinhole camera if we don't have one placing it in a way to look at the entire space.
let canvas_size = glam::vec2(canvas_from_ui.to().width(), canvas_from_ui.to().height());
let default_principal_point = canvas_size * 0.5;
let default_principal_point = canvas_from_ui.to().center();
let default_principal_point = glam::vec2(default_principal_point.x, default_principal_point.y);
let pinhole = pinhole.unwrap_or_else(|| {
let focal_length_in_pixels = canvas_size.x;

Expand Down