Add scripts/run_all.py
#2046
Merged
Add scripts/run_all.py
#2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
force-pushed
the
jan/run-all-examples
branch
from
17539d0 to
e06cce4
Compare
jprochazk
added
🧑💻 dev experience
emilk
requested changes
May 4, 2023
scripts/run_all.py
Outdated
| from glob import glob | ||
|
|
||
|
|
||
| def run_py_example(path: str, args: list[str] = []) -> None: |
There was a problem hiding this comment.
This fails on my Python 3.8.12 with:
❯ scripts/run_all.py
Traceback (most recent call last):
File "scripts/run_all.py", line 12, in <module>
def run_py_example(path: str, args: list[str] = []) -> None:
TypeError: 'type' object is not subscriptable
I assume you are using a newer Python?
Of course, this being python, the linter doesn't catch this 🤦 (Python 3.8 is our minimum supported version, and what is used on CI)
What we do elsewhere is from typing import List and then args: List[str].
There was a problem hiding this comment.
Yeah, I'm currently on 3.10. I guess I'll also downgrade to 3.8 to catch this stuff earlier.
There was a problem hiding this comment.
$ python --version
Python 3.8.16
jprochazk
force-pushed
the
jan/run-all-examples
branch
from
e3ca9e7 to
2894bdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #1945
This PR adds
scripts/run_all.pywhich is a port of thepy-run-allrecipe in thejustfile.Checklist
PR Build Summary: https://build.rerun.io/pr/2046