[refactor] Move Caches to re_viewer_ctx and make it generic
#2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
📺 re_viewer
emilk
approved these changes
May 4, 2023
| fn purge_memory(&mut self); | ||
|
|
||
| /// Converts itself to a mutable reference of [`Any`], which enables mutable downcasting to concrete types. | ||
| fn as_any_mut(&mut self) -> &mut dyn Any; |
There was a problem hiding this comment.
It would be great with an fn bytes_used(&self) -> usize here too. Then we could easily iterate over all caches and show them in the memory panel!
There was a problem hiding this comment.
liking that idea a lot. I'll add a todo, want to move on with the actual refactoring quickly :)
…ntry` for brevity & consistency!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards moving
ViewerContexttore_viewer_ctx. Makes itscachesfield a container of generic caches and introduces aCachetrait that we can use throughout the viewer for.. caching things!It is expected that the store will take over more and more of that functionality, but meanwhile this is a nice home for what we have and will make it easier to move it again.
Part of:
re_viewer#1873Checklist
PR Build Summary: https://build.rerun.io/pr/2043