Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pure refactor] Move item-ui to separate module, move AppOptions to re_viewer_context #2040

Merged
merged 5 commits into from
May 4, 2023
Merged

[pure refactor] Move item-ui to separate module, move AppOptions to re_viewer_context #2040

merged 5 commits into from
May 4, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 4, 2023

... both of which are towards the goal of being able to move out ViewerContext to re_viewer_context which then will allow a wave of new crates that don't depend on re_viewer, but only on re_viewer_context

Suitable for per-commit review!

Part of:

What

Checklist

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality labels May 4, 2023
@Wumpf
Copy link
Member Author

Wumpf commented May 4, 2023

I wanted AppOptions not to be part of the context but reconsidered then - it is nice to have experimental flags in there for the time being that we can use from all sort of places

@emilk emilk self-requested a review May 4, 2023 10:37
emilk
emilk approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress!

@Wumpf Wumpf merged commit 181ed01 into main May 4, 2023
@Wumpf Wumpf deleted the andreas/move-item-ui-out-of-viewercontext branch May 4, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @emilk