Add an experimental text-box component and logtype #2011
Conversation
jleibs
added
🐍 Python API
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct TextboxEntry { | ||
| pub body: String, |
There was a problem hiding this comment.
| pub body: String, | |
| pub body: String, // TODO(#1887): avoid allocations |
There was a problem hiding this comment.
Ahh, nice. That ticket also suggests:
We should also take the time to split TextEntry into two components: text and level.
Maybe we should just do that all now.
There was a problem hiding this comment.
It feels like the new view this PR introduces should just be a different view of the same component. The TextLog view shows text over time, while the new TextBox view shows the latest text(s) at the given time. That would make the difference a difference in blueprint, not in data or component type.
There was a problem hiding this comment.
(If only we had a way to choose the view in the blueprint 😅)
Having a marker-component to hint at the right View and different APIs for logging still seems important for user discoverability and ergonomics. These are very different use-cases. Forcing blueprint-interactions to differentiate them doesn’t feel like a great experience.
A fun use-case for this feature: all our examples could log their own source-code so that when you view one of our examples, you have easy access to the source that created it. If we have a MIME component (or similar) then we could add syntax highlighting to the shown code. |
|
Should we draft this as "blocked by #1887" then? |
|
Let's put this behind some sort of experimental namespace and merge this |
jleibs
changed the title
| #[serde(default)] | ||
| pub struct ViewTextBoxState { | ||
| monospace: bool, | ||
| word_wrap: bool, |
There was a problem hiding this comment.
Doesn't it make more sense for word wrapping to be on by default?
There was a problem hiding this comment.
Yeah, that's a fair point. I guess I'm so used to text-editor contexts where I self-wrap that I forgot how bad an experience it is to have non-wrapped lines not end up wrapping.
* New UI for displaying a textbox * Add new TextBox component to simplify view-category creation * Make module experimental * Move to experimental designation * Add experimental APIs to docs * Python import cleanup * Default word_wrap to true and set autoshrink to false for the scroll area
emilk
changed the title
I wanted to just include some updating text as part of the view layout and realized that our "log-style" text entries weren't exactly what I wanted. Some of the naming here is probably worth discussing. In particular, how this should (or shouldn't) line up with the TextEntry logging APIs which serve a very different purpose with a very different view.
Seems like there could be some fun extensions on top of this to do HTML, Markdown, etc. for dynamically showing content along with the data. Seems particularly relevant with all the LLM / Prompt stuff going on these days.
Example of the motivating use-case:
typing-rerun.mp4
This feature is gated behind a new
experimentalmodule:Checklist
PR Build Summary: https://build.rerun.io/pr/2011