-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failure to save files when split table contains no data #2007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice with a regression test of this too, if it is not too much trouble.
I think we should merge this into main
first, then cherry-pick it into a 0.5.1
branch. This will ensure it ends up correctly in the changelog (and that it gets main
-lined quicker)
Ok, rebased to main so we can cherry-pick back to hotfix. |
crates/re_arrow_store/tests/dump.rs
Outdated
] => 3; [instances2, points2]); | ||
let mut table = DataTable::from_rows(TableId::random(), [row1, row2]); | ||
table.compute_all_size_bytes(); | ||
store.insert_table(&table).ok(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should crash on errors in tests, no?
here and below
store.insert_table(&table).ok(); | |
store.insert_table(&table).unwrap(); |
The root cause of the problem was arrow failing to concatenate if there was no data in the table. This checks for that condition and bypasses the serialize_data_column call all together.
The root cause of the problem was arrow failing to concatenate if there was no data in the table. This checks for that condition and bypasses the serialize_data_column call all together.
Fixes:
What
The root cause of the problem was arrow failing to concatenate if there was no data in the table. This checks for that condition and bypasses the
serialize_data_column
call all together.Added new test that fails with same conditions:
Checklist
PR Build Summary: https://build.rerun.io/pr/2007