SDK batching/revamp 2.2: homegrown arrow size estimation routines #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
force-pushed
the
cmc/sdk_revamp/22_batching_estimated_size_hell
branch
from
b41f4ea to
33a60ac
Compare
teh-cmc
force-pushed
the
cmc/sdk_revamp/22_batching_estimated_size_hell
branch
2 times, most recently
from
aece2df to
25ca19c
Compare
teh-cmc
force-pushed
the
cmc/sdk_revamp/22_batching_estimated_size_hell
branch
from
c5522fe to
f8e74e9
Compare
teh-cmc
force-pushed
the
cmc/sdk_revamp/22_batching_estimated_size_hell
branch
from
d0cd877 to
da160c5
Compare
teh-cmc
changed the title
estimated_bytes_size + Union + batching = disaster
This was referenced May 3, 2023
6 tasks
…ching_estimated_size_hell
teh-cmc
commented
May 4, 2023
jleibs
requested changes
May 4, 2023
jleibs
reviewed
May 4, 2023
Comment on lines
+366
to
+369
| let mut idx_end = idx_start; | ||
| for idx in indices { | ||
| idx_end = idx; | ||
| } |
There was a problem hiding this comment.
Suggested change
| let mut idx_end = idx_start; | |
| for idx in indices { | |
| idx_end = idx; | |
| } | |
| let idx_end = indices.last().unwrap_or_default(); |
There was a problem hiding this comment.
Yeah... I didn't go there because it very much looks like this is some magic 0(1) function, which feels like I'm betraying the reader...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of all size measurement issues (incl. batch support) and makes sure they won't bother us again, at least until the migration to
arrow1.Don't be fooled by the line-changed numbers, it's all either tests or shuffling code around. All the relevant stuff is confined to the new
estimated_bytes_sizefunction insize_bytes.rs.On top of #1983
Checks: