-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK batching/revamp 2.1: clock
example for Rust
#2000
Conversation
e4d53b8
to
c2e39a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, works as documented. Nice to have more rust examples for testing
#[rustfmt::skip] | ||
log_hand(rec_stream, "seconds", step, (step % 60) as f32 / 60.0, LENGTH_S, WIDTH_S, 0)?; | ||
#[rustfmt::skip] | ||
log_hand(rec_stream, "minutes", step, (step % 3600) as f32 / 3600.0, LENGTH_M, WIDTH_M, 128)?; | ||
#[rustfmt::skip] | ||
log_hand(rec_stream, "hours", step, (step % 43200) as f32 / 43200.0, LENGTH_H, WIDTH_H, 255)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[rustfmt::skip]
doesn't work on a block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not on expressions, it's been nightly-only since the dawn of time... 😒
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you need to update cargo.lock again, noticed only when switching to a different branch now:
diff --git a/Cargo.lock b/Cargo.lock
index 304bd0417..2124b977e 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -773,7 +773,7 @@ name = "clock"
version = "0.6.0-alpha.0"
dependencies = [
"anyhow",
- "clap 4.1.4",
+ "clap 4.1.14",
"glam",
"rerun",
]
ah too late, uhoh. Guess this might give @jprochazk the main ci failure test 😄 |
Argh, these things drive me insane. Eh, it'll get lazily fixed by the next PR I guess... |
Which will be in about ten minutes thanks to #2026 👀 |
Doesn't seem to have caused a failure 😢 |
Yeah I'm not surprised: outdated lock files are annoying because they screw with everyone's local copy, but I don't remember we ever configured anything to detect these situations on the CI. |
What the title says.
On top of #1983