Better crash reports on Web + WebGPU support detection #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
;) |
emilk
previously requested changes
Apr 26, 2023
|
still need to test the notebook, waiting for webbuilder to finish because it's easiest using https://app.rerun.io/commit/5e26952 |
|
confirmed working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using egui's new ability to pass through errors on panic and otherwise for better crashes on the web:
Screen.Recording.2023-04-26.at.14.28.30.mov
Additionally, added detection for running webgpu version on a non-webgpu browser:
What
Checklist
PR Build Summary: https://build.rerun.io/pr/1975