Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover/select highlights when picking single points in a scene with multiple point clouds #1942

Merged
merged 1 commit into from
Apr 20, 2023
+3 −1
Merged

Fix hover/select highlights when picking single points in a scene with multiple point clouds #1942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/re_renderer/src/renderer/point_cloud.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ pub struct PointCloudBatchInfo {

/// Defines an outline mask for an individual vertex ranges.
///
/// Vertex ranges are *not* relative within the current batch, but relates to the draw data vertex buffer.
/// Vertex ranges are relative within the current batch.
///
/// Having many of these individual outline masks can be slow as they require each their own uniform buffer & draw call.
/// This feature is meant for a limited number of "extra selections"
Expand Down Expand Up @@ -455,6 +455,8 @@ impl PointCloudDrawData {
));

for (range, _) in &batch_info.additional_outline_mask_ids_vertex_ranges {
let range = (range.start + start_point_for_next_batch)
..(range.end + start_point_for_next_batch);
batches_internal.push(point_renderer.create_point_cloud_batch(
ctx,
format!("{:?} strip-only {:?}", batch_info.label, range).into(),
Expand Down