Rust 1.69.0 + remove toolchain confusion
#1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
force-pushed
the
cmc/ci/rust_1_69
branch
from
22ce269
to
f0bb2fc
Compare
teh-cmc
added
enhancement
teh-cmc
commented
May 2, 2023
teh-cmc
force-pushed
the
cmc/ci/rust_1_69
branch
2 times, most recently
from
cdc23b9
to
de1b132
Compare
emilk
requested changes
May 2, 2023
| @@ -101,7 +101,7 @@ serde = { version = "1", features = ["derive"] } | |||
| slotmap = { version = "1.0.6", features = ["serde"] } | |||
| smallvec = { workspace = true, features = ["serde"] } | |||
| thiserror.workspace = true | |||
| time = { workspace = true, default-features = false, features = ["formatting"] } | |||
There was a problem hiding this comment.
Is it an error to set fault-features = false both here and in the root Cargo.toml?
There was a problem hiding this comment.
It depends on the context...
If you're within the workspace, then the root Cargo.toml "wins" and this effectively does nothing since time is considered to not have any default features.
But what happens when you import re_viewer directly in an external project: surely the root manifest doesn't take precedence then...? or does it??! I'll test this for #2024...
Co-authored-by: Emil Ernerfeldt <[email protected]>
emilk
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions-rs/toolchain: it just adds confusion, we're overriding it viarust-toolchainwhen building (whether we're in a docker runner, or a vanilla macOS/Windows)!1.69.0Newly surfaced issues:
wasmparser(indirect dep) about to break #2022rerun_pyalways enables all ofrerun's default-flags #2024Checks:
pip install ./rerun_py && just py-run-alljust py-run-all-webusing CI wheelPR Build Summary: https://build.rerun.io/pr/1935