-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gpu picking for points, streamline/share picking code some more #1814
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
15bae45
use gpu picking for picking points
Wumpf 8c352c6
correct "click-through" behavior for point picking
Wumpf 8258ce0
gpu based picking no longer works like a fallback but integrates with…
Wumpf d147534
fix incorrect cursor rounding for picking
Wumpf 71caa74
wip
Wumpf aa60783
work out correct picking for 2D views with zooming & panning
Wumpf e47c043
refactor picking context to be a pub struct with exposed state
Wumpf ecbc6d7
Merge remote-tracking branch 'origin/main' into andreas/use-gpu-picki…
Wumpf 3167f2f
unify ui picking method for 2d & 3d space views
Wumpf b2bff8d
less indentation for picking method
Wumpf 307f1d2
picking rect size is dynamically choosen
Wumpf adbd4f9
fix accidental z scaling in projection correction for picking
Wumpf 2e41891
comment mentioning #1818
Wumpf 8fcba7a
make cropped_projection_from_projection easier to read
Wumpf d7512aa
comment and naming fixes
Wumpf bf6274e
Merge remote-tracking branch 'origin/main' into andreas/use-gpu-picki…
Wumpf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could easily enforce that or at least warn/debug_assert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so turns out the entire interface has this stuff which is kinda bonkers (and my fault). Was thinking about this in relation to #1779 (crash on too many points). Need to overhaul this a bit. Will take in a followup