Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on depth cloud backprojection by default #1710

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 25, 2023

Closes #1586

Or rather: turn it on by default for 3D views, but off by default for 2D views.

Checklist

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself labels Mar 25, 2023
@teh-cmc teh-cmc self-requested a review March 27, 2023 06:29
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

My only concern (which is unrelated to this PR) is how nice and smooth it looks when hovering the manually backprojected points versus the depth cloud:

Points selected:
image

Backprojected cloud selected:
image

@emilk
Copy link
Member Author

emilk commented Mar 27, 2023

Yeah, you are right that the hovering isn't great… I'll see if I can do something quick to improve that.

@emilk
Copy link
Member Author

emilk commented Mar 27, 2023

I'll try to fix the outlines in a separate PR

@emilk emilk merged commit 2ea2cd8 into main Mar 27, 2023
@emilk emilk deleted the emilk/backporject-by-default branch March 27, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn depth backprojection on by default
2 participants