Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging meshes without colors #1680

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Fix logging meshes without colors #1680

merged 2 commits into from
Mar 23, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 23, 2023

This broke the raw_mesh demo since _normalize_colors outputs an empty np array when passed None and the other side expects a certain dimensionality

Checklist

@Wumpf Wumpf added 🦟 regression A thing that used to work in an earlier release 📺 re_viewer affects re_viewer itself 🐍 Python API Python logging API and removed 📺 re_viewer affects re_viewer itself labels Mar 23, 2023
emilk
emilk approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tack!

@emilk emilk merged commit b557ec7 into main Mar 23, 2023
@emilk emilk deleted the andreas/fix-logging-meshes-without-colors branch March 23, 2023 09:03
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🐍 Python API Python logging API 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @emilk