Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow url param override on app.rerun.io #1678

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Allow url param override on app.rerun.io #1678

merged 2 commits into from
Mar 23, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 22, 2023

The logic to provide a default url from javascript was preventing the old ?url param behavior from working. If url param is provided we now pass that through directly.

The other option would be for web.rs to always default to the url param if provided, but I can imagine other cases where the hosting web app wants full control over the url-param, so I think this is the preferable way of solving the problem.

Checklist

@jleibs jleibs marked this pull request as ready for review March 22, 2023 22:42
@jleibs jleibs added the 🕸️ web regarding running the viewer in a browser label Mar 22, 2023
@emilk emilk merged commit 8fb3751 into main Mar 23, 2023
@emilk emilk deleted the jleibs/allow_url_param branch March 23, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants