Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner about mobile browsers being unsupported #1674

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Add banner about mobile browsers being unsupported #1674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6f9c16
Add banner about missing support on mobile browsers
jleibs Mar 22, 2023
dd15af8
Clarify mobile isn't supported in general (not just limited to web)
jleibs Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions crates/re_viewer/src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,10 +1012,12 @@ impl AppState {
}
}

fn warning_panel(re_ui: &re_ui::ReUi, ui: &mut egui::Ui, frame: &mut eframe::Frame) {
// We have some bugs when running the web viewer on Windows.
// See https://github.com/rerun-io/rerun/issues/1206
if frame.is_web() && ui.ctx().os() == egui::os::OperatingSystem::Windows {
fn warning_panel(re_ui: &re_ui::ReUi, ui: &mut egui::Ui, _frame: &mut eframe::Frame) {
// We have not yet optimized the UI experience for mobile. Show a warning banner
// with a link to the tracking issue.
if ui.ctx().os() == egui::os::OperatingSystem::IOS
|| ui.ctx().os() == egui::os::OperatingSystem::Android
{
let frame = egui::Frame {
fill: ui.visuals().panel_fill,
..re_ui.bottom_panel_frame()
Expand All @@ -1026,10 +1028,9 @@ fn warning_panel(re_ui: &re_ui::ReUi, ui: &mut egui::Ui, frame: &mut eframe::Fra
.frame(frame)
.show_inside(ui, |ui| {
ui.centered_and_justified(|ui| {
let text = re_ui.warning_text(
"The web viewer has some known issues on Windows. Click for details.",
);
ui.hyperlink_to(text, "https://github.com/rerun-io/rerun/issues/1206");
let text =
re_ui.warning_text("Mobile OSes are not yet supported. Click for details.");
ui.hyperlink_to(text, "https://github.com/rerun-io/rerun/issues/1672");
});
});
}
Expand Down