Upload the colmap rrd file to gcloud #1666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency logic is a bit awkward, but in lieu of a larger workflow reorganization this is the easiest path to uploading an rrd file to gcloud.
In short: we generate an rrd file when producing the wheels (and also need the wheels in order to produce the colmap rrd). This means any time we build wheels we will also upload an rrd file, but this is the same conditions where we upload the web asserts.
In the future it would be nice to have wheel-building, rrd-generation, and web-uploading all in a single workflow instead of the way they are split up at the moment. The "python vs rust" partitioning isn't actually buying us much.
Checklist