Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect failure to install GUI log callback #1655

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Detect failure to install GUI log callback #1655

merged 3 commits into from
Mar 22, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 21, 2023

Only if one uses re_log::setup_native(); can we add a GUI hook to the log stream, and users using the rerun crate and calling spawn will likely not have done so.

Yet another reason to dislike the rust-sdk:s spawn method. We should fork or something instead.

Checklist

@emilk emilk added the 📺 re_viewer affects re_viewer itself label Mar 21, 2023
@emilk emilk merged commit dac6286 into main Mar 22, 2023
@emilk emilk deleted the emilk/fix-logger-snafu branch March 22, 2023 07:05
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @jleibs