-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --all-features to Rust Analyzer flags #1624
Conversation
This stops it from building the web viewer, since `crates/re_web_viewer_server/build.rs` checks the `__ci` feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the fix that I expected. Great to have it confirmed not stomping on our webviewer files!!!
And tanks for all the warning fixes!!
.vscode/settings.json
Outdated
@@ -52,7 +52,8 @@ | |||
"--target-dir=target_ra", | |||
"--workspace", | |||
"--message-format=json", | |||
"--all-targets" | |||
"--all-targets", | |||
"--all-features", // --all-features is critical in order to stop crates/re_web_viewer_server/build.rs from building the web viewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still counter-intuitive to me. I tried reading through build.rs
and even there it's not obvious why adding "all-features" here would stop the web-viewer from being built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, piecing this comment together with the PR description I guess this is because "--all-features" implies the the CI "feature" which prevents the web-build.
"--all-features", // --all-features is critical in order to stop crates/re_web_viewer_server/build.rs from building the web viewer | |
"--all-features", // --all-features will set the `ci` feature flag, which stops crates/re_web_viewer_server/build.rs from building the web viewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added: 5948394
Btw, this still works:
that's because Only when there is no |
This stops rust-analyzer from building the web viewer, since
crates/re_web_viewer_server/build.rs
checks the__ci
featureChecklist