-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sensitive data from analytics #1563
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
approved these changes
Mar 13, 2023
Wumpf
approved these changes
Mar 13, 2023
emilk
added a commit
that referenced
this pull request
Mar 13, 2023
* Analytics: Anonymize the file path of the location of a panic * Remove git_branch from analytics
emilk
added a commit
that referenced
this pull request
Mar 13, 2023
* Analytics: Anonymize the file path of the location of a panic * Remove git_branch from analytics
This was referenced Mar 13, 2023
Closed
Summary of issue
ResolutionIn addition to fixing the code we have made sure to scrub all analytics databases of any traces of the leaked non-anonymized paths and git branch names. We have also set up server side filters to drop the affected data before ingestion to avoid any of this data getting to our analytics databases in the future.
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to anonymize the file path in the
file:line
location of panics, which means we are leaking full paths into our analytics, which can include user names, which is really bad.We also had the rerun
git_branch
included (for users building from source), which can also contain sensitive stuff.All affected analytics event have been deleted, and new ones will be filtered.
A patch-release is coming in
Checklist