Implement outlines for rectangles & use them for select & hover of image primitives in Viewer #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
ui
jleibs
approved these changes
Mar 10, 2023
Wumpf
force-pushed
the
andreas/outline-based-selection-for-line-like
branch
from
f6f9071 to
5862ca6
Compare
Base automatically changed from
andreas/outline-based-selection-for-line-like
to
main
March 10, 2023 19:00
…viewer for images
Wumpf
force-pushed
the
andreas/outline-based-selection-for-rectangles
branch
from
459f4a2 to
f2727ec
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
back in the habit! Part of #889
Showing some 2D things for a change - the inward extending outline actually saves us here.
https://user-images.githubusercontent.com/1220815/224327611-72238bf5-86f7-4e20-8eaf-06465bc2d534.mov
And some "artificial" 3D (everywhere else we have camera lines around it, stealing the show)
Checklist