Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogDb: dont split on index bucket size #1558

Merged
merged 1 commit into from
Mar 10, 2023
Merged

LogDb: dont split on index bucket size #1558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/re_data_store/src/log_db.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,15 @@ impl Default for EntityDb {
InstanceKey::name(),
DataStoreConfig {
component_bucket_size_bytes: 1024 * 1024, // 1 MiB
index_bucket_size_bytes: 1024, // 1KiB
// We do not garbage collect index buckets at the moment, and so the size of
// individual index buckets is irrelevant, only their total number of rows
// matter.
// See <pr-link> for details.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, i thought I pushed the commit with the link, but turns out i didnt press enter in the terminal 🤦‍♂️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll slip it in one the upcoming GC PRs, it's fiiiiiiiine

//
// TODO(cmc): Bring back index GC once the whole `MsgId` mismatch issue is
// resolved (probably once batching is implemented).
index_bucket_size_bytes: u64::MAX,
index_bucket_nb_rows: 2048,
..Default::default()
},
),
Expand Down