Fix combining outline mask for selection & hover #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
ui
jleibs
reviewed
Mar 10, 2023
jleibs
approved these changes
Mar 10, 2023
| @@ -37,19 +37,19 @@ impl MeshPart { | |||
|
|
|||
| let _default_color = DefaultColor::EntityPath(ent_path); | |||
| let world_from_obj_affine = glam::Affine3A::from_mat4(world_from_obj); | |||
| let entity_outlines = highlights.entity_outline_mask(ent_path.hash()); | |||
| let entity_highlight = highlights.entity_outline_mask(ent_path.hash()); | |||
There was a problem hiding this comment.
The intermixing of "highlight" and "outline" as concepts could probably use some attention at some point.
There was a problem hiding this comment.
as you can see I went back and forth a bit: They are a form of highlights and soon the only one that's why I went back to calling it highlight 🤔
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hovering a an entity of an already selected group:
Before:
nothing happens!
After:
Get expected "internal" hover highlight!
Checklist