Use outlines for mesh selections instead of highlight colors #1540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses outlines for selection/hovering of meshes.
mesh.outlines.sd.mov
Introduces a sibling data structure to
SpaceViewEntityHighlight
in order to quickly get the desired grouping-aware outline mask indices, calledSpaceViewOutlineMasks
.SpaceViewOutlineMasks
will likely fully replaceSpaceViewEntityHighlight
in the near future; in any case a bit more work in this area is needed; consider this a first quick-and-dirty step!Color choices etc. are not considered final, but a first step. We'll go over them again when everything is changed to outlines instead of highlights.
Copy pasting a few other notes I posted previously on the internal Slack:
*Previously, we distinguished “sibling selections”, i.e. you select something in one space view and there is a different (!) highlight in another space view where the same object is visible. That’s gone now because I can only support 2 channels at the moment
Checklist
part of #889