Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore: disable compaction (fixes 2x memory issue) #1535

Merged
merged 4 commits into from
Mar 9, 2023
Merged

datastore: disable compaction (fixes 2x memory issue) #1535

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42de80c
disable compaction until we support batching
teh-cmc Mar 8, 2023
8c2ebe1
link
teh-cmc Mar 8, 2023
621bcf8
Merge branch 'main' into cmc/disable_archives
teh-cmc Mar 9, 2023
90bb1de
make it configurable
teh-cmc Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/re_arrow_store/src/store_write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,8 +1107,13 @@ impl ComponentTable {
"allocating new component bucket, previous one overflowed"
);

// Archive currently active bucket.
active_bucket.archive();
// TODO(cmc): Compaction is disabled until we implement batching.
// See https://github.com/rerun-io/rerun/pull/1535 for rationale.
//
// This has no noticeable impact on importance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we back up this claim with data?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added benchmarks

//
// // Archive currently active bucket.
// active_bucket.archive();

let row_offset = active_bucket.row_offset + len;
self.buckets
Expand Down Expand Up @@ -1215,6 +1220,7 @@ impl ComponentBucket {
/// Archives the bucket as a new one is about to take its place.
///
/// This is a good opportunity to run compaction and other maintenance related tasks.
#[allow(dead_code)]
pub fn archive(&mut self) {
crate::profile_function!();

Expand Down