Proper rustc & LLVM versions #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added a commit
that referenced
this pull request
Mar 6, 2023
* Refactor: move the session log sink to its own file
* Turn LogSink into a trait
* Move spawning of native viewer to `rerun` crate
* Move the `show()` method to `rerun` crate
* re_sdk no longer depend directly on re_viewer
* Prevent re_viewer from accidentally depending on re_web_viewer_server
* Improve doc-strings
* Remove the native_viewer feature from re_sdk
* Remove direct dependency of rerun_py on re_sdk_comms
* Small doc-fixes
* Move `clap` hookup from `re_sdk` to `rerun`
* Move the `session.serve()` method to trait `rerun::WebViewerSessionExt`
* cleanup
* Remove cyclic-dependency-protection because it caused weird warning:
The lib target `re_viewer` in package `re_viewer v0.2.0 (/Users/emilk/code/rerun/rerun/crates/re_viewer)` has the same output filename as the lib target `re_viewer` in package `re_viewer v0.2.0 (/Users/emilk/code/rerun/rerun/crates/re_viewer)`.
* Fix web-viewer
* Fix python build
* Fix remove_dir_all RUSTSEC
❯ cargo update -p tempfile
Updating crates.io index
Removing remove_dir_all v0.5.3
Updating tempfile v3.3.0 -> v3.4.0
* Trim re_sdk dependency list
* Fix doc-tests
* Fix doclinks
* Document rust_version
* Better docs for set_sink
* Hide `global_session()` behind the `global` feature flag
* Fix typos
* Proper rustc & LLVM versions (#1512)
* add rustc & llvm version to build crates
* integrate everywhere
* crash handler too
* Rename "global" feature to "global_session"
* Replace extension trait with `serve_web_viewer` method
---------
Co-authored-by: Clement Rey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1509
Also keeps track of LLVM version while we're at it, since we've already seen many lavapipe/llvmpipe related issues already...