Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal log_text_entry_internal to break circular deps #1488

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 2, 2023

Importing log_text_entry from the decorator used to decorate the log_text_entry itself is problematic. Split text.py into the external-facing facing user API and a slimmed down internal version we can use from within our other API calls.

Also the calls checking strict_mode weren't valid. Not sure how this ever worked?

Checklist

@jleibs jleibs marked this pull request as ready for review March 2, 2023 21:13
@jleibs jleibs added 🐍 Python API Python logging API 🧑‍💻 dev experience developer experience (excluding CI) dependencies concerning crates, pip packages etc labels Mar 2, 2023
@jleibs jleibs requested a review from emilk March 2, 2023 21:29
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, this is on me. I don't know how I managed to mess up testing so completely. I must have run against the wrong rerun-sdk 🤦

Thanks for the fix ❤️

@jleibs jleibs merged commit 7691eee into main Mar 2, 2023
@jleibs jleibs deleted the jleibs/break_circular_dep branch March 2, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc 🧑‍💻 dev experience developer experience (excluding CI) 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants