Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU & GPU color maps #1484

Merged
merged 15 commits into from
Mar 3, 2023
Merged

CPU & GPU color maps #1484

merged 15 commits into from
Mar 3, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Mar 2, 2023 •
edited
Loading

  • Just the color maps, both CPU & GPU
  • Only polynomial approximations so that we don't end up with different results depending on where the color mapping is done
  • Drop the previous Viridis colormap (LUT based) for the reason above
  • Color maps are now exposed by re_renderer so that everything can benefit without having to import re_viewer

Definitely don't review by on a commit-by-commit basis: they don't make sense, most of them have been salvaged by cherry picking from my gazillon local branches

PR will follow shortly which integrates these with depth clouds.

@teh-cmc teh-cmc added ui concerns graphical user interface 🔺 re_renderer affects re_renderer itself labels Mar 2, 2023
teh-cmc added a commit that referenced this pull request Mar 2, 2023
@teh-cmc
squashed #1484
7e6a476
@teh-cmc teh-cmc mentioned this pull request Mar 2, 2023
Merged
@Wumpf Wumpf self-requested a review March 2, 2023 18:26
Wumpf
Wumpf approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all very clean!
(I haven't compared impls or even verified them ;))

crates/re_renderer/shader/colormap.wgsl Show resolved Hide resolved
@teh-cmc teh-cmc merged commit 15b04f7 into main Mar 3, 2023
@teh-cmc teh-cmc deleted the cmc/depth_clouds/colormapping branch March 3, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk left review comments

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🔺 re_renderer affects re_renderer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teh-cmc @emilk @Wumpf