Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re_renderer: Arrow buffers as (optional) first-class citizen #1482

Merged
merged 30 commits into from
Mar 3, 2023
Merged

re_renderer: Arrow buffers as (optional) first-class citizen #1482

merged 30 commits into from
Mar 3, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Mar 2, 2023 •
edited
Loading

Requires #1421

Make re_renderer aware of arrow types (behind a feature flag), so that we don't waste time on unnecessary giant allocations & memcopies.

teh-cmc added 23 commits March 2, 2023 14:56
@teh-cmc teh-cmc added enhancement New feature or request 🔺 re_renderer affects re_renderer itself 🏹 arrow concerning arrow 🚀 performance Optimization, memory use, etc labels Mar 2, 2023
emilk
emilk approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Does this give any visible speedup on our examples?

crates/re_renderer/src/renderer/depth_cloud.rs Outdated Show resolved Hide resolved
crates/re_renderer/Cargo.toml Show resolved Hide resolved
Base automatically changed from cmc/depth_clouds_integration to main March 3, 2023 10:23
@teh-cmc
Copy link
Member Author

teh-cmc commented Mar 3, 2023

Nice! Does this give any visible speedup on our examples?

Yeah actually, much more than I expected oO

When I crank up the visible history to really put pressure on it, there's up to 25% difference in framerate depending on the frame 😱

@teh-cmc teh-cmc merged commit 042240e into main Mar 3, 2023
@teh-cmc teh-cmc deleted the cmc/re_renderer_arrow branch March 3, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🏹 arrow concerning arrow enhancement New feature or request 🚀 performance Optimization, memory use, etc 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @emilk