Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python SDK: Add strict mode #1477

Merged
merged 9 commits into from
Mar 2, 2023
Merged

Python SDK: Add strict mode #1477

merged 9 commits into from
Mar 2, 2023

Commits on Mar 2, 2023

  1. Python SDK: Add a decorator to all out logging function to early-out 

    This replaces explicit checks with a decorator.

This decorator declaration preserves type information
in Python 3.8 in my VSCode, which was a problem with previous attempts.

In a follow-up PR we can add a try-catch to the decorator to prevent
errors from bubbling up to the user.
    @emilk
    emilk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    7ece3b6 View commit details
    Browse the repository at this point in the history

  2. Catch and log exceptions in log_decorator

    @emilk
    emilk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    e34ba4b View commit details
    Browse the repository at this point in the history

  3. Replace a few _send_warning with raise

    @emilk
    emilk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    57b857a View commit details
    Browse the repository at this point in the history

  4. Make strict-mode opt-in

    @emilk
    emilk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    e8eeb45 View commit details
    Browse the repository at this point in the history

  5. Clean up scripts/lint.py

    @emilk
    emilk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    cb912cd View commit details
    Browse the repository at this point in the history

  6. emil should learn to type and and spellcheck 

    Co-authored-by: Andreas Reich <[email protected]>
    @emilk @Wumpf
    emilk and Wumpf authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    ab8b149 View commit details
    Browse the repository at this point in the history

  7. can we get automated spell checking of docstrings? 

    Co-authored-by: Andreas Reich <[email protected]>
    @emilk @Wumpf
    emilk and Wumpf authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    977128c View commit details
    Browse the repository at this point in the history

  8. surely there is a spell checker for python docstrings, right? 

    Co-authored-by: Andreas Reich <[email protected]>
    @emilk @Wumpf
    emilk and Wumpf authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    f76d85e View commit details
    Browse the repository at this point in the history

  9. not misuses - incorrect use

    @emilk
    emilk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    3df4f3d View commit details
    Browse the repository at this point in the history