Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mesh creation failing to copy index data. #1473

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Fix mesh creation failing to copy index data. #1473

merged 1 commit into from
Mar 2, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 2, 2023

  • fix wrong index data size
  • fix dubious copy_to_buffer copy size on CpuWriteGpuReadBuffer

Fixes #1467

Checklist

@Wumpf
Fix mesh creation failing to copy index data.
e2b21ef 
* fix wrong index data size
* fix dubious `copy_to_buffer` copy size on `CpuWriteGpuReadBuffer`
Fixes #1467
@Wumpf Wumpf added 🔺 re_renderer affects re_renderer itself 💣 crash crash, deadlock/freeze, do-no-start labels Mar 2, 2023
@Wumpf Wumpf merged commit 35ea4a3 into main Mar 2, 2023
@Wumpf Wumpf deleted the andreas/re_renderer/fix-mesh-copy-crash branch March 2, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
💣 crash crash, deadlock/freeze, do-no-start 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New crash on linux when logging meshes
2 participants
@Wumpf @emilk