Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify bind group allocation call by passing pool collection object. #1459

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Simplify bind group allocation call by passing pool collection object. #1459

merged 1 commit into from
Mar 1, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 1, 2023

Got tired of all these parameters and since BindGroupPool::alloc recently became non-mut, this can be easily simplified.

Checklist

@Wumpf
Simplify bind group allocation call by passing pool collection object.
ac43078 
Got tired of all these parameters and since `BindGroupPool::alloc` recently became non-mut, this can be easily simplified.
@Wumpf Wumpf added 🔺 re_renderer affects re_renderer itself 🧑‍💻 dev experience developer experience (excluding CI) and removed 🧑‍💻 dev experience developer experience (excluding CI) labels Mar 1, 2023
emilk
emilk approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice ❤️

@Wumpf Wumpf merged commit 8dc3e46 into main Mar 1, 2023
@Wumpf Wumpf deleted the andreas/re_renderer/pass-pools-to-bindgroup-pool branch March 1, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @emilk