Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for f16 tensors #1449

Merged
merged 4 commits into from
May 10, 2023
Merged

Add support for f16 tensors #1449

merged 4 commits into from
May 10, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 28, 2023 •
edited
Loading

Blocked by: DataEngineeringLabs/arrow2-convert#104

Resolves: #854

T = np.random.rand(10, 10, 10).astype(np.float16)
rr.log_tensor("f16_tensor", T)

T = np.random.rand(10, 10).astype(np.float16)
rr.log_image("f16_img_mono", T)

T = np.random.rand(10, 10, 3).astype(np.float16)
rr.log_image("f16_img_rgb", T)

image

Checklist

@jleibs jleibs marked this pull request as ready for review February 28, 2023 18:09
@jleibs jleibs added the 🏹 arrow concerning arrow label Feb 28, 2023
Base automatically changed from jleibs/tensor_view_without_classic to main February 28, 2023 18:11
@jleibs jleibs force-pushed the jleibs/arrow_f16_support branch from 9b83da8 to cc927cf Compare February 28, 2023 18:11
@jleibs jleibs added the ⛃ re_datastore affects the datastore itself label Feb 28, 2023
@emilk emilk marked this pull request as draft February 28, 2023 18:19
@emilk
Copy link
Member

emilk commented Feb 28, 2023

Converted to draft since this is blocked on this being merged and released:

@emilk emilk added the blocked can't make progress right now label Feb 28, 2023
@jleibs
Copy link
Member Author

jleibs commented Feb 28, 2023

Will need to rebase this once we land: https://github.com/rerun-io/rerun/pull/1455/files

@jleibs jleibs force-pushed the jleibs/arrow_f16_support branch from cc927cf to 8174b8e Compare March 3, 2023 19:47
@jleibs jleibs force-pushed the jleibs/arrow_f16_support branch from 8174b8e to 04ff2c6 Compare May 9, 2023 14:36
@jleibs jleibs marked this pull request as ready for review May 9, 2023 14:38
@jleibs jleibs removed the blocked can't make progress right now label May 9, 2023
emilk
emilk approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, those are some ugly (but sadly necessary) work-arounds

@jleibs jleibs merged commit 5319928 into main May 10, 2023
@jleibs jleibs deleted the jleibs/arrow_f16_support branch May 10, 2023 11:44
jprochazk pushed a commit that referenced this pull request May 11, 2023
@jleibs @jprochazk
Add support for f16 tensors (#1449)
a557354 
* Add support for f16 tensors
* Make half::f16 ndarrays work as well
@Wumpf Wumpf added enhancement New feature or request 📺 re_viewer affects re_viewer itself labels Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🏹 arrow concerning arrow enhancement New feature or request ⛃ re_datastore affects the datastore itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native F16 support for arrow tensors
3 participants
@jleibs @emilk @Wumpf