Versioned log streams streams #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
enhancement
teh-cmc
approved these changes
Feb 28, 2023
emilk
added a commit
that referenced
this pull request
Mar 2, 2023
* Parse the rust version into a semver-like struct * Encode rust version in LogMsg streams, and warn on incompatibility * Add explanation of how to treat alpha-releases * Better error message * Fix link in docstring
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encodes the full Rerun version in our log streams (networked and .rrd files). When loading a stream a warning will be logged if the versions are potentially incompatible.
This PR also constrains the Rerun version to always be on the pattern
X.Y.Z[-alpha.W]. With (X,Y,Z,W)<255. This allows us to always encode the version in 32 bits.Closes #873
Checklist