[re_renderer] Introduce DrawPhasees for simplistic multi pass rendering
#1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dering Or rather as a first and super easy step towards it. Also takes the first step towards supporting transparency, see #702 Replaces previous sorting key! Very simple idea: Every `Renderer` is invoked with every `DrawPhase` it registered for. `DrawPhase` have a strict order and implicitly describe the `wgpu::RenderPass` that is passed for drawing. For now and forseeable future, these passes are managed by the ViewBuilder (unchanged!). At some point we will probably make `DrawPhase` a more complex object, but this is not today!
emilk
approved these changes
Feb 27, 2023
|
oops, added a wip file. reverting! |
Wumpf
force-pushed
the
andreas/re_renderer/phases
branch
from
248dd6e to
9b990f3
Compare
Wumpf
changed the title
DrawPhasees for simpl(istic) multi pass renderingDrawPhasees for simplistic multi pass rendering
emilk
pushed a commit
that referenced
this pull request
Mar 2, 2023
…ring (#1419) Or rather as a first and super easy step towards it. Also takes the first step towards supporting transparency, see #702 Replaces previous sorting key! Very simple idea: Every `Renderer` is invoked with every `DrawPhase` it registered for. `DrawPhase` have a strict order and implicitly describe the `wgpu::RenderPass` that is passed for drawing. For now and forseeable future, these passes are managed by the ViewBuilder (unchanged!). At some point we will probably make `DrawPhase` a more complex object, but this is not today!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or rather as a first and super easy step towards it. Also takes the first step towards supporting transparency, see #702 Replaces previous sorting key!
Very simple idea: Every
Rendereris invoked with everyDrawPhaseit registered for.DrawPhasehave a strict order and implicitly describe thewgpu::RenderPassthat is passed for drawing.Nice perk is that our previously very special composition renderer is now just another regular renderer - the only one interested in the
Compositionphase!For now and forseeable future, these passes are managed by the ViewBuilder (unchanged!). At some point we will probably make
DrawPhasea more complex object, but this is not today!Checklist
CHANGELOG.md(if this is a big enough change to warrant it)