Introduce DeserializableComponent trait and high-level query_latest
#1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
commented
Feb 27, 2023
teh-cmc
commented
Feb 27, 2023
teh-cmc
added
🏹 arrow
Wumpf
approved these changes
Feb 27, 2023
| /// A [`Component`] that fulfils all the conditions required to be deserialized from an Arrow | ||
| /// payload. | ||
| /// | ||
| /// Note that due to the use of HRTBs in `arrow2_convert` traits, you will still need an extra HRTB |
There was a problem hiding this comment.
https://doc.rust-lang.org/nomicon/hrtb.html
An old-school workaround for the lack of generic associated types... which actually have landed since then, at least in part.
We should be able to make those APIs in arrow2_convert friendlier pretty soon.
| /// we check to see if it exists in the arrow storage. | ||
| pub fn query_transform( | ||
| /// Get the latest value for a given [`re_log_types::msg_bundle::Component`]. | ||
| pub fn query_latest<C: DeserializableComponent>( |
There was a problem hiding this comment.
should there be something in the name or comment on how this expects that there is only a single component of the type on the entity?
There was a problem hiding this comment.
That's already guaranteed by the data model 🤔 Ha, you mean a single instance. Yes.
emilk
pushed a commit
that referenced
this pull request
Mar 2, 2023
…t` (#1417) * introduce DeserializableComponent * turn query_transform into a generic query_latest * use DeserializableComponent everywhere it makes sense * use SerializableComponent everywhere it makes sense * self review * addressed PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
DeserializableComponenttrait (which does what you think it does and means what you think it means) and uses it everywhere it makes sense.Also fixed a bunch of places where
SerializableComponentwasn't used yet.In addition to this, this generalizes the
query_transformfunction (that we use in a bunch of places in the UI to fetch the latest transform of a given entity path) to any component.We do so because I now have the need to fetch stuff other than transforms when displaying the selection panel.