-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash-on-save by switching file-picker dialog to xdg-portal
#1402
Conversation
50bc063
to
ed25446
Compare
3f1e549
to
6611dc4
Compare
.github/workflows/python.yml
Outdated
@@ -2,10 +2,6 @@ name: CI (Python) | |||
|
|||
on: | |||
pull_request: | |||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to restrict wheel-building to only when we have changed python code.
- We want to catch if if we break the wheel by changing rust code
- We want to be able to build new wheels based on changes to the rust code
Unsurprisingly: doesn't work on an Arch system with nothing but a |
Blocked by new release of |
38f164d
to
8936285
Compare
On wlroots systems, one would be expected to have
That's planed already, I want to use Zenity (and KDialog) for that in RFD, just haven't had the time to do that. Eventually I would like to remove GTK all together in favor of Zenity, and use it as fallback only for those "bloat" free systems. |
Hey @PolyMeilex, thanks for the heads up. I've tried installing I'll also try your Zenity branch while I'm at it then. Will get back to you asap. |
Can confirm that both Message and File dialogs work fine for me using the |
rfd 0.11.3 has been released, and I've updated to it. Please test this @teh-cmc ! EDIT: ouch, that's A LOT of new dependencies… 😬 |
@@ -2,6 +2,7 @@ name: CI (Python) | |||
|
|||
on: | |||
pull_request: | |||
types: [labeled, synchronize, opened] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentional or merge conflict?
Yep, dialogs working fine over here |
I'll see if I can fix the duplicated deps and get |
9e11edb
to
4379c8b
Compare
I believe this is ready to be merged then |
xdg-portal
Not ready to merge yet, but want to create CI-built wheels.
In particular need to figure out alternative to the MessageDialogs.
Resolves: #1315
Test wheels from CI:
xdg-desktop-portal-gtk
)Checklist
CHANGELOG.md
(if this is a big enough change to warrant it)